HomePhabricator

[mlir-reduce] Add doc for usage of mlir-reduce

Authored by Chia-hungDuan on Jun 29 2021, 3:03 AM.

Description

[mlir-reduce] Add doc for usage of mlir-reduce

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D103683

Details

Committed
Chia-hungDuanJun 29 2021, 3:20 AM
Reviewer
jpienaar
Differential Revision
D103683: [mlir-reduce] Add doc for usage of mlir-reduce
Parents
rG371ee32e01a7: [ARM] Fold extract of ARM_BUILD_VECTOR
Branches
Unknown
Tags
Unknown

Event Timeline

Grammatical comments through line 32.

/mlir/docs/Tools/mlir-reduce.md
23

input. it generates

“it” should be capitalized.

adopts reduction-tree algorithm

Insert “the” before “reduction-tree algorithm.”

24

do

Should be “does”.

25–26

may lead to different
result

“to different result” should be either “to different results” or “to a different result”.

29

testing interesting

Should be “testing interestingness”.

31–32

which case
you're interesting.

“which case you're interested in.” would be idiomatic, and is, I think, what you mean.

Chia-hungDuan marked 5 inline comments as done.Jul 8 2021, 5:22 AM

Thanks, addressed here, https://reviews.llvm.org/D105623

/mlir/docs/Tools/mlir-reduce.md
25–26

Use "different results"