Diffusion LLVM Github Monorepo 7b3eabdcd215

[OPENMP][NVPTX]Fix PR40893: Size doesn't match for…
7b3eabdcd215
Actions

Authored by ABataev on Mar 13 2019, 11:21 AM.

Description

[OPENMP][NVPTX]Fix PR40893: Size doesn't match for '_openmp_teams_reductions_buffer_$_.

nvlink does not handle weak linkage correctly, same symbols with the
different sizes are reported as erroneous though the largest size must
be chosen instead. Patch fixes this problem by using Internal linkage
instead of the Common.

llvm-svn: 356072

Details

Committed

ABataev

Mar 13 2019, 11:21 AM

Parents

rG510f26dca8a9: Regenerate test

Branches

Unknown

Tags

Unknown

Event Timeline

ABataev committed rG7b3eabdcd215: [OPENMP][NVPTX]Fix PR40893: Size doesn't match for… (authored by ABataev).Mar 13 2019, 11:21 AM

Is this bug only for common linkage, or does it also affect weakanylinkage? If so, we should update setPropertyExecutionMode to use internal as well

In rG7b3eabdcd2155ecd171ac8d80abe638dd3dc5c65#954573, @JonChesterfield wrote:

Is this bug only for common linkage, or does it also affect weakanylinkage? If so, we should update setPropertyExecutionMode to use internal as well

This is for weak linkage only.

Was that a typo? The patch changed common to internal. I'd quite like all the shared variables to have consistent linkage, with a mild preference for not-internal.

I don't remeber already. Probably, common linkage is emitted as weak in NVPTX codegen.

That's very plausible. Thanks, will experiment.

JonChesterfield mentioned this in D89994: [libomptarget][nvptx] Undef, internal shared variables.Oct 22 2020, 4:22 PM

JonChesterfield mentioned this in D90248: [libomptarget][nvptx] Undef, weak shared variables.Oct 27 2020, 9:50 AM

JonChesterfield mentioned this in rG5d02ca49a294: [libomptarget][nvptx] Undef, weak shared variables.Oct 28 2020, 7:25 AM