HomePhabricator

On Windows, handle interrupt signals without crash message

Authored by jhenderson on May 13 2020, 2:29 AM.

Description

On Windows, handle interrupt signals without crash message

For LLVM on *nix systems, the signal handlers are not run on signals
such as SIGINT due to CTRL-C. See sys::CleanupOnSignal. This makes
sense, as such signals are not really crashes. Prior to this change,
this wasn't the case on Windows, however. This patch changes the Windows
behaviour to be consistent with Linux, and adds testing that verifies
this.

The test uses llvm-symbolizer, but any tool with an interactive mode
would do the job.

Fixes https://bugs.llvm.org/show_bug.cgi?id=45754.

Reviewed by: MaskRay, rnk, aganea

Differential Revision: https://reviews.llvm.org/D79847

Details

Committed
jhendersonMay 21 2020, 5:27 AM
Reviewer
MaskRay
Differential Revision
D79847: [Support] On Windows, handle interrupt signals without crash message
Parents
rGb263fee4d2c9: [CostModel] Sink intrinsic costs to base TTI.
Branches
Unknown
Tags
Unknown