HomePhabricator

[mlir] Change the default of `mlir-print-op-on-diagnostic` to true

Authored by rriddle on Apr 3 2020, 7:02 PM.

Description

[mlir] Change the default of mlir-print-op-on-diagnostic to true

Summary: It is a very common user trap to think that the location printed along with the diagnostic is the same as the current operation that caused the error. This revision changes the behavior to always print the current operation, except for when diagnostics are being verified. This is achieved by moving the command line flags in IR/ to be options on the MLIRContext.

Differential Revision: https://reviews.llvm.org/D77095

Details