Simplify MachineVerifier's block-successor verification.
There's two properties we want to verify:
- That the successors returned by analyzeBranch are in the CFG successor list, and
- That there are no extraneous successors are in the CFG successor list.
The previous implementation mostly accomplished this, but in a very
Differential Revision: https://reviews.llvm.org/D79793