HomePhabricator

LowerTypeTests: Improve performance by optimising type metadata queries.

Authored by pcc on Dec 6 2016, 3:02 PM.

Description

LowerTypeTests: Improve performance by optimising type metadata queries.

Requesting metadata for a global is a relatively expensive operation as it
involves a map lookup, but it's one that we need to do relatively frequently in
this pass to collect the list of type metadata nodes associated with a global.
This change improves the performance of type metadata queries by prebuilding
data structures that keep the global together with its list of type metadata,
and changing the pass to use that data structure wherever we were previously
passing global references around.

This change also eliminates some O(N^2) behavior by collecting the list of
globals associated with each type identifier during the first pass over the
list of globals rather than visiting each global to compute that list every
time we add a new type identifier.

Reduces pass runtime on a module containing Chrome's vtables from over 60s
to 0.9s.

Differential Revision: https://reviews.llvm.org/D27484

llvm-svn: 288859

Details

Committed
pccDec 6 2016, 3:02 PM
Differential Revision
D27484: LowerTypeTests: Improve performance by optimising type metadata queries.
Parents
rG0559b9e557ad: [X86][XOP] Add test case for PR31296
Branches
Unknown
Tags
Unknown