Diffusion LLVM Github Monorepo 722b61892454

eliminate nontrivial Reset(...) from TypedPythonObject
722b61892454
Actions

Authored by lawrence_danna on Oct 19 2019, 11:43 AM.

Description

eliminate nontrivial Reset(...) from TypedPythonObject

Summary:
This deletes Reset(...), except for the no-argument form Reset()
from TypedPythonObject, and therefore from PythonString, PythonList,
etc.

It updates the various callers to use assignment, As<>, Take<>,
and Retain<>, as appropriate.

followon to https://reviews.llvm.org/D69080

Reviewers: JDevlieghere, clayborg, labath, jingham

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69133

llvm-svn: 375350

Details

Committed

lawrence_danna

Oct 19 2019, 11:43 AM

Reviewer

labath

Differential Revision

D69133: eliminate nontrivial Reset(...) from TypedPythonObject

Parents

rG1d509201e2d2: [SCEV] Simplify umin/max of zext and sext of the same value

Branches

Unknown

Tags

Unknown

Event Timeline

lawrence_danna committed rG722b61892454: eliminate nontrivial Reset(...) from TypedPythonObject (authored by lawrence_danna).Oct 19 2019, 11:43 AM

Changes (4)

				Path	Packages
	M			lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
	M			lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
	M			lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
	M			lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp