HomePhabricator

[HIP] Handle compile -m options and propagate into LLC

Authored by ashi1 on Feb 13 2019, 8:12 AM.

Description

[HIP] Handle compile -m options and propagate into LLC

Allow the compile options for -m such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 to propagate into LLC args. Fix an issue where -mattr was pushed even when it was empty.

Also add lit tests to verify features are properly passed.

Differential Revision: https://reviews.llvm.org/D57977

Reviewers: yaxunl, kzhuravl
llvm-svn: 353952

Details

Committed
ashi1Feb 13 2019, 8:12 AM
Differential Revision
D57977: [HIP] compile option code-object-v3 propagate to llc
Parents
rG6a03b93224dd: [llvm-readobj] Rename pr_data to PrData
Branches
Unknown
Tags
Unknown

Event Timeline

yaxunl added a subscriber: yaxunl.Feb 13 2019, 10:52 AM

It seem we only need to remove -mattr=-code-object-v3. we do not need to handle the feature options e.g. -mcode-object-v3 here, since they will be automatically pass to clang -cc1 and handled by clang -cc1. Your can keep the test since it is still correct.