HomePhabricator

[VNCoercion] Disallow coercion between different ni addrspaces

Authored by vchuravy on Dec 7 2020, 1:13 PM.

Description

[VNCoercion] Disallow coercion between different ni addrspaces

I'm not sure if it would be legal by the IR reference to introduce
an addrspacecast here, since the IR reference is a bit vague on
the exact semantics, but at least for our usage of it (and I
suspect for many other's usage) it is not. For us, addrspacecasts
between non-integral address spaces carry frontend information that the
optimizer cannot deduce afterwards in a generic way (though we
have frontend specific passes in our pipline that do propagate
these). In any case, I'm sure nobody is using it this way at
the moment, since it would have introduced inttoptrs, which
are definitely illegal.

Fixes PR38375

Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>

Reviewed By: reames

Differential Revision: https://reviews.llvm.org/D50010

Details

Committed
vchuravyDec 7 2020, 5:19 PM
Reviewer
reames
Differential Revision
D50010: [VNCoercion] Disallow coercion between different ni addrspaces
Parents
rGefc063b621ea: Fix lit test failure due to 0b81d9
Branches
Unknown
Tags
Unknown