HomePhabricator

DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI.

Authored by RKSimon on Sep 20 2020, 6:42 AM.

Description

DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI.

We were using Err after it had been moved into cantFail - avoid this by calling cantFail with Error::success() directly.

Details

Committed
RKSimonSep 20 2020, 6:42 AM
Parents
rG91720ee561b2: [X86] combineX86ShufflesRecursively - fix use after move warning. NFCI.
Branches
Unknown
Tags
Unknown

Event Timeline

Higuoxing added inline comments.
/llvm/lib/ObjectYAML/DWARFEmitter.cpp
1036

Hi @RKSimon, it looks that we can delete this line since cantFail(Error::success()) does nothing here.

RKSimon added inline comments.Sep 20 2020, 9:45 AM
/llvm/lib/ObjectYAML/DWARFEmitter.cpp
1036

Even better - cheers!