HomePhabricator

[clangd] Fix race in Global CDB shutdown

Authored by sammccall on Feb 2 2021, 6:20 AM.

Description

[clangd] Fix race in Global CDB shutdown

I believe the atomic write can be reordered after the notify, and that
seems to be happening on mac m1: http://45.33.8.238/macm1/2654/step_8.txt
In practice maybe seq_cst is enough? But no reason not to lock here.

https://bugs.llvm.org/show_bug.cgi?id=48998

Details

Committed
sammccallFeb 2 2021, 6:24 AM
Parents
rG9e5fc578f99a: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source
Branches
Unknown
Tags
Unknown