HomePhabricator
Diffusion LLVM Github Monorepo 69d67d3d8049

[IndexDataStore] Sort unit names using std::sort()
69d67d3d8049Unpublished
Actions

Authored by rintaro on May 9 2019, 9:55 AM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[IndexDataStore] Sort unit names using std::sort()

std::string is not POD.

apple-llvm-split-commit: dcd292d511866c4fe33a90c6a37b9cf640458216
apple-llvm-split-dir: clang/

Details

Committed
rintaroMay 9 2019, 12:05 PM
Parents
rGfeb4a903a85e: Merge remote-tracking branch 'llvmorg/master' into upstream-with-swift
Branches
Unknown
Tags
Unknown

Event Timeline

rintaro committed rG69d67d3d8049: [IndexDataStore] Sort unit names using std::sort() (authored by rintaro).May 9 2019, 12:05 PM
mgrang added a subscriber: mgrang.Dec 12 2019, 2:29 PM
mgrang added inline comments.
/clang/lib/IndexDataStore/IndexDataStore.cpp
88

Please use the range-based llvm::sort function here. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.

llvm::sort(filenames);

Changes (1)

PathSize
clang/
lib/
IndexDataStore/

rG69d67d3d8049

View Options

clang/lib/IndexDataStore/IndexDataStore.cpp

Loading...