HomePhabricator

use_lldb_suite.py: Fix potential infinite loop

Authored by labath on Feb 7 2019, 6:03 AM.

Description

use_lldb_suite.py: Fix potential infinite loop

The loop searching for use_lldb_suite_root had a bug where if the marker
file happened to be missing, it would enter an infinite loop. While this
shouldn't happen in normal circumstances, it can happen accidentally,
and debugging it is not very pleasant.

The loop had an exit condition, but it was incorrent (os.path.dirname
returning None). This will never happen as dirname will just return the
same folder over and over again once it reaches the root folder. This
fixes the exit condition to account for that.

llvm-svn: 353406

Details

Committed
labathFeb 7 2019, 6:03 AM
Parents
rG76016ba1ca86: Fix some warnings introduced in r353324 (ReproducerInstrumentation patch)
Branches
Unknown
Tags
Unknown