HomePhabricator

[clang-format] Adds a formatter for aligning arrays of structs
Concern Raised673c5ba58497

Authored by feg208 on Jun 13 2021, 7:36 AM.

Description

[clang-format] Adds a formatter for aligning arrays of structs

This adds a new formatter to arrange array of struct initializers into
neat columns.

Differential Revision: https://reviews.llvm.org/D101868

Event Timeline

jansvoboda11 raised a concern with this commit.Jun 14 2021, 3:18 AM
jansvoboda11 added a subscriber: jansvoboda11.

This causes a bunch of build bot failures:

Please fix main or revert this commit if the fix isn't obvious. Thanks.

This commit now has outstanding concerns.Jun 14 2021, 3:18 AM
feg208 added a comment.EditedJun 14 2021, 6:37 AM

Ok. I am going to see if I can replicate the issue locally. Otherwise the easiest path (imho) is to pull the lit test that is failing. It isn't telling us anything we don't already know from the unit tests in any case. But maybe its something odd like the spacing or the single '-' in the option flags on FileCheck