HomePhabricator

Codegen, NFC: 32bit test in auto-var-init.cpp
Audit Required669ad5ff1502

Authored by vitalybuka on Jul 11 2019, 6:36 PM.

Description

Codegen, NFC: 32bit test in auto-var-init.cpp

llvm-svn: 365857

Details

Auditors
jfb
Committed
vitalybukaJul 11 2019, 6:36 PM
Parents
rGd49103bd2ff3: Mark destroying delete test as UNSUPPORTED with clang 7
Branches
Unknown
Tags
Unknown

Event Timeline

This commit now requires audit.Jul 11 2019, 6:54 PM
vitalybuka added a subscriber: jfb.Jul 11 2019, 6:58 PM

Hi @jfb
Here I've added 32bit test and landed it without review as it's simple and does not change existing tests, I thought. Unfortunately later I realized that I've killed some alignment checks.
I don't think that they are important here. If you disagree, I can make something to return them.

jfb added a comment.Jul 12 2019, 9:16 AM

Hi @jfb
Here I've added 32bit test and landed it without review as it's simple and does not change existing tests, I thought. Unfortunately later I realized that I've killed some alignment checks.
I don't think that they are important here. If you disagree, I can make something to return them.

I think it's fine, we've got some alignment tests already so it's unlikely to regress.