HomePhabricator

[InferAttrs] Add argmemonly attribute to string libcalls

Authored by xbolva00 on Sat, Oct 17, 1:23 PM.

Description

[InferAttrs] Add argmemonly attribute to string libcalls

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D89602

Details

Event Timeline

Why were the sanitizer tests deleted? It seems to me like they are valid. If the new attributes causes them to be optimized out can't you just build them with -fno-builtin?

Why were the sanitizer tests deleted? It seems to me like they are valid. If the new attributes causes them to be optimized out can't you just build them with -fno-builtin?

There are now optimized out due to overlap. I will check if no builtin could fix it - if yes, i will push them back.

Why were the sanitizer tests deleted? It seems to me like they are valid. If the new attributes causes them to be optimized out can't you just build them with -fno-builtin?

There are now optimized out due to overlap. I will check if no builtin could fix it - if yes, i will push them back.

If not, maybe just deleting the -O1/-O2/-O3 variants might also work?

Ok, no-builtin fix works fine