HomePhabricator

[lldb/Test] Introduce "assertSuccess"
63829d077edfUnpublished

Authored by labath on Jun 29 2020, 4:51 AM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[lldb/Test] Introduce "assertSuccess"

Summary:
A lot of our tests do 'self.assertTrue(error.Success()'. The problem
with that is that when this fails, it produces a completely useless
error message (False is not True) and the most important piece of
information -- the actual error message -- is completely hidden.

Sometimes we mitigate that by including the error message in the "msg"
argument, but this has two additional problems:

  • as the msg argument is evaluated unconditionally, one needs to be careful to not trigger an exception when the operation was actually successful.
  • it requires more typing, which means we often don't do it

assertSuccess solves these problems by taking the entire SBError object
as an argument. If the operation was unsuccessful, it can format a
reasonable error message itself. The function still accepts a "msg"
argument, which can include any additional context, but this context now
does not need to include the error message.

To demonstrate usage, I replace a number of existing assertTrue
assertions with the new function. As this process is not easily
automatable, I have just manually updated a representative sample. In
some cases, I did not update the code to use assertSuccess, but I went
for even higher-level assertion apis (runCmd, expect_expr), as these are
even shorter, and can produce even better failure messages.

Reviewers: teemperor, JDevlieghere

Subscribers: arphaman, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D82759

(cherry picked from commit 35674976f09ec99e74d0d28b4a64b6bce360c128)

Details

Committed
teemperorJul 7 2020, 3:49 AM
Differential Revision
D82759: [lldb/Test] Introduce "assertSuccess"
Parents
rG893c4d2230ca: Merge pull request #1423 from adrian-prantl/63840635-2
Branches
Unknown
Tags
Unknown