HomePhabricator

Make HasWinCFI a plain bool instead of Optional<bool>

Authored by ssijaric on Aug 31 2018, 5:33 PM.

Description

Make HasWinCFI a plain bool instead of Optional<bool>

Summary:
Reid suggested making HasWinCFI a plain bool defaulting to false in D50288.

It's needed in order to add HasWinCFI to MIRPrinter. Otherwise, we'll get the
assertion:

HasWinCFI.hasValue() && "HasWinCFI not set yet!"'

Also, a few ARM64 Windows test cases will fail with the same assert if the ARM64
MCLayer part of EH work (D50166) goes in before the frame lowering part that
sets HasWinCFI (D50288 as of now).

Reviewers: rnk, mstorsjo, hans, javed.absar

Reviewed By: rnk

Subscribers: kristof.beyls, llvm-commits

Differential Revision: https://reviews.llvm.org/D51560

llvm-svn: 341270

Details

Committed
ssijaricAug 31 2018, 5:33 PM
Reviewer
rnk
Differential Revision
D51560: Make HasWinCFI a plain bool instead of Optional<bool>
Parents
rGf5297fb24bf0: [Constant Hoisting] Hoisting Constant GEP Expressions
Branches
Unknown
Tags
Unknown