HomePhabricator

Convert Log class to llvm streams

Authored by labath on Feb 10 2017, 3:49 AM.

Description

Convert Log class to llvm streams

Summary:
This converts LLDB's logging to use llvm streams instead of
lldb_private::Stream and friends. The changes are mostly
straight-forward and amount to s/lldb_private::Stream/llvm::raw_ostream.

The part worth calling out is the rewrite of the StreamCallback class.
Previously this class contained a per-thread buffer of data written. I
assume this had something to do with it trying to make sure each log
line is delivered as a single event, instead of multiple (possibly
interleaved) events. However, this is no longer relevant as the Log
class already writes things to a temporary buffer and then delivers the
message as a single "write", so I have just removed the code in
question.

Reviewers: zturner, clayborg

Subscribers: emaste, lldb-commits, mgorny

Differential Revision: https://reviews.llvm.org/D29615

llvm-svn: 294736

Details

Committed
labathFeb 10 2017, 3:49 AM
Differential Revision
D29615: Convert Log class to llvm streams
Parents
rG30a02088c0dc: Porting the example illustrating Polly from HTML to reStructuredText
Branches
Unknown
Tags
Unknown