HomePhabricator

[ScalarEvolution] Fix overflow in computeBECount.

Authored by efriedma on Jun 29 2021, 3:22 PM.

Description

[ScalarEvolution] Fix overflow in computeBECount.

There are two issues with the current implementation of computeBECount:

  1. It doesn't account for the possibility that adding "Stride - 1" to

Delta might overflow. For almost all loops, it doesn't, but it's not
actually proven anywhere.

  1. It doesn't account for the possibility that Stride is zero. If Delta

is zero, the backedge is never taken; the value of Stride isn't
relevant. To handle this, we have to make sure that the expression
returned by computeBECount evaluates to zero.

To deal with this, add two new checks:

  1. Use a variety of tricks to try to prove that the addition doesn't

overflow. If the proof is impossible, use an alternate sequence which
never overflows.

  1. Use umax(Stride, 1) to handle the possibility that Stride is zero.

Differential Revision: https://reviews.llvm.org/D105216