HomePhabricator

clang/Modules: Split loop in ReadAST between failable and not

Authored by dexonsmith on Nov 10 2019, 10:50 AM.

Description

clang/Modules: Split loop in ReadAST between failable and not

Split a loop in ReadAST that visits the just-loaded module chain,
between an initial loop that reads further from the ASTs (and can fail)
and a second loop that does some preloading (and cannot fail). This
makes it less likely for a reading failure to affect the AST.

This is not fixing a known bug and the behaviour change may not be
observable, it's just part of an audit to look at all of the error
handling in the ASTReader.

https://reviews.llvm.org/D70056
(cherry picked from commit 01782c3e4df1830d7991e9edfee9119ed41e4c27)

Details

Committed
dexonsmithNov 12 2019, 9:03 AM
Parents
rGa08033917c5d: clang/Modules: Use range-based for in ASTReader::ReadAST, NFC
Branches
Unknown
Tags
Unknown