HomePhabricator

Re-apply:" Emit DW_OP_implicit_value for Floating point constants"

Authored by SouraVX on Jul 22 2020, 6:51 PM.

Description

Re-apply:" Emit DW_OP_implicit_value for Floating point constants"

This patch was reverted in 9d2da6759b4d due to assertion failure seen
in test/DebugInfo/Sparc/subreg.ll. Assertion failure was happening
due to malformed/unhandeled DwarfExpression.

Differential Revision: https://reviews.llvm.org/D83560

Event Timeline

amyk added a subscriber: amyk.Jul 23 2020, 2:17 PM

Hi there!
I believe this patch is causing failures on the following (big endian) PowerPC buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/
http://lab.llvm.org:8011/builders/clang-ppc64be-linux

Example of the failures can be seen at: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/51729

Could you please fix or pull this changeset if necessary? Thank you.

Hi there!
I believe this patch is causing failures on the following (big endian) PowerPC buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/
http://lab.llvm.org:8011/builders/clang-ppc64be-linux

Example of the failures can be seen at: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/51729

Could you please fix or pull this changeset if necessary? Thank you.

There appears to be an implicit assumption of the host machine being little endian in this patch. So it broke both the PowerPC big endian as well as SystemZ bots (also big endian). Please pull the patch.