HomePhabricator

Be conservative about unordered accesses for the moment

Authored by reames on Feb 11 2019, 3:34 PM.

Description

Be conservative about unordered accesses for the moment

Background: As described in https://reviews.llvm.org/D57601, I'm working towards separating volatile and atomic in the MMO uses for atomic instructions.

In https://reviews.llvm.org/D57593, I fixed a bug where isUnordered was returning the wrong result, but didn't account for the fact I was getting slightly ahead of myself. While both uses of isUnordered are correct (as far as I can tell), we don't have tests to demonstrate this and being aggressive gets in the way of having the removal of volatile truly be non-functional. Once D57601 lands, I will return to these call sites, revert this patch, and add the appropriate tests to show the expected behaviour.

Differential Revision: https://reviews.llvm.org/D57802

llvm-svn: 353766

Details

Committed
reamesFeb 11 2019, 3:34 PM
Differential Revision
D57802: Be conservative about unordered accesses for the moment
Parents
rGe3cd735ea637: Add a new attribute, fortify_stdlib
Branches
Unknown
Tags
Unknown