Diffusion LLVM Github Monorepo 4b33b2387787

Reapply "[LV] Vectorize (some) early and multiple exit loops"" w/fix for builder
Concern Raised4b33b2387787
Actions

Authored by reames on Dec 28 2020, 10:11 AM.

Description

Reapply "[LV] Vectorize (some) early and multiple exit loops"" w/fix for builder

This reverts commit 4ffcd4fe9ac2ee948948f732baa16663eb63f1c7 thus restoring e4df6a40dad.

The only change from the original patch is to add "llvm::" before the call to empty(iterator_range). This is a speculative fix for the ambiguity reported on some builders.

Details

Auditors

markus

Committed

reames

Dec 28 2020, 10:13 AM

Parents

rG4ffcd4fe9ac2: Revert "[LV] Vectorize (some) early and multiple exit loops"

Branches

Unknown

Tags

Unknown

Reverts

rG4ffcd4fe9ac2: Revert "[LV] Vectorize (some) early and multiple exit loops"

Event Timeline

reames committed rG4b33b2387787: Reapply "[LV] Vectorize (some) early and multiple exit loops"" w/fix for builder (authored by reames).Dec 28 2020, 10:13 AM

reames added a reverted change: rG4ffcd4fe9ac2: Revert "[LV] Vectorize (some) early and multiple exit loops".

This commit seem to cause

$ opt -verify -loop-vectorize bbi-51639.ll -S
opt: /repo/elavkje/llvm-project-upstream/llvm/lib/Transforms/Utils/LoopVersioning.cpp:47: llvm::LoopVersioning::LoopVersioning(const llvm::LoopAccessInfo &, ArrayRef<llvm::RuntimePointerCheck>, llvm::Loop *, llvm::LoopInfo *, llvm::DominatorTree *, llv
m::ScalarEvolution *): Assertion `L->getExitBlock() && "No single exit block"' failed.

bbi-51639.ll852 BDownload

This commit now has outstanding concerns.Jan 12 2021, 2:55 AM

In rG4b33b2387787aef5020450cdcc8dde231eb0a5fc#969612, @markus wrote:

This commit seem to cause

$ opt -verify -loop-vectorize bbi-51639.ll -S
opt: /repo/elavkje/llvm-project-upstream/llvm/lib/Transforms/Utils/LoopVersioning.cpp:47: llvm::LoopVersioning::LoopVersioning(const llvm::LoopAccessInfo &, ArrayRef<llvm::RuntimePointerCheck>, llvm::Loop *, llvm::LoopInfo *, llvm::DominatorTree *, llv
m::ScalarEvolution *): Assertion `L->getExitBlock() && "No single exit block"' failed.

bbi-51639.ll852 BDownload

Fixed in commit caafdf07b. This was a spurious assert.