HomePhabricator

[OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp

Authored by jdenny on Nov 20 2018, 2:05 PM.

Description

[OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp

This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within a block of CHECK-DAG
directives. Thus, this patch also removes uses of FileCheck's
-allow-deprecated-dag-overlap command-line option.

There were two issues in this test:

  1. There were sets of patterns for store instructions in which a

pattern X could match a superset of a pattern Y. While X appeared
before Y, Y's intended match appeared before X's intended match. The
result was that X matched Y's intended match. Under the old
overlapping behavior, Y also matched Y's intended match. Under the
new non-overlapping behavior, Y had nothing left to match. This patch
fixes this by gathering these sets in one place and putting the most
specific patterns (Y) before the more general patterns (X).

  1. The CHECK-DAG patterns involving the variables CBPADDR3 and

CBPADDR4 were the same, but there was only one match in the text, so
CBPADDR4 patterns had nothing to match under the new non-overlapping
behavior. Moreover, a preceding related series of directives had
variables (SADDR0, BPADDR0, etc.) numbered only 0 through 4, but this
series had variables numbered 0 through 5. Assuming CBPADDR4's
directives were not intended, this patch removes them.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D54765

llvm-svn: 347351

Details

Committed
jdennyNov 20 2018, 2:05 PM
Reviewer
ABataev
Differential Revision
D54765: [OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp
Parents
rGd586bc6db992: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp
Branches
Unknown
Tags
Unknown