HomePhabricator

[LLDB] [PECOFF] Fix error handling for executables that object::createBinary…

Authored by mstorsjo on Oct 30 2019, 2:57 PM.

Description

[LLDB] [PECOFF] Fix error handling for executables that object::createBinary errors out on

llvm::object::createBinary returns an Expected<>, which requires
not only checking the object for success, but also requires consuming
the Error, if one was set.

Use LLDB_LOG_ERROR for this case, and change an existing similar log
statement to use it as well, to make sure the Error is consumed even
if the log channel is disabled.

Differential Revision: https://reviews.llvm.org/D69646