HomePhabricator

[update_cc_test_checks.py] Use CHECK_RE from common

Authored by arichardson on Dec 2 2019, 10:18 AM.

Description

[update_cc_test_checks.py] Use CHECK_RE from common

Summary:
This change modifies the common.CHECK_RE regex to also handle '//'
comment prefixes which allows us to share it between clang and IR tests.
Using the regex from common means that *-SAME lines are also stripped
now. Before this change using the --function-signature flag would result
in -SAME: lines from previous runs not being removed.

Reviewers: MaskRay, jdoerfert

Reviewed By: jdoerfert

Subscribers: jdoerfert, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70890

Details

Committed
arichardsonDec 2 2019, 10:18 AM
Reviewer
jdoerfert
Differential Revision
D70890: [update_cc_test_checks.py] Use CHECK_RE from common
Parents
rG62ab949248d8: [lit] Be more explicit about the state of tests
Branches
Unknown
Tags
Unknown

Event Timeline

Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> committed rG3b55eebd239e: [update_cc_test_checks.py] Use CHECK_RE from common (authored by Alex Richardson <Alexander.Richardson@cl.cam.ac.uk>).Dec 2 2019, 10:18 AM