HomePhabricator

Address post commit review comments on revision 366727.
Audit Required39f35038140d

Authored by sfertile on Jul 30 2019, 8:37 AM.

Description

Address post commit review comments on revision 366727.

Addresses number of comment made on D64652 after commiting:

  • Reorders function decls in the TargetLoweringObjectFileXCOFF class.
  • Fix comment in MCSectionXCOFF to include description of external reference csects.
  • Convert several llvm_unreachables to report_fatal_error
  • Convert several dyn_casts to casts as they are expected not to fail.
  • Avoid copying DataLayout object.

llvm-svn: 367324

Details

Auditors
grosbach
Committed
sfertileJul 30 2019, 8:37 AM
Parents
rG027bb52790ed: [COFF][ARM64] Reorder handling of aarch64 MSVC builtins
Branches
Unknown
Tags
Unknown