HomePhabricator

[clangd] Improve code completion for ObjC methods

Authored by sammccall on Nov 14 2018, 1:05 AM.

Description

[clangd] Improve code completion for ObjC methods

Summary:
Previously code completion did not work well for Objective-C methods
which contained multiple arguments as clangd did not expect to see
multiple typed-text chunks when handling code completion.

Note that even with this change, we do not consider selector fragments
from previous arguments to be part of the signature (although we
could in the future).

Reviewers: sammccall

Reviewed By: sammccall

Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, jfb, kadircet, cfe-commits

Differential Revision: https://reviews.llvm.org/D53934

llvm-svn: 346836

Details

Committed
sammccallNov 14 2018, 1:05 AM
Reviewer
sammccall
Differential Revision
D53934: [clangd] Improve code completion for ObjC methods
Parents
rG2634bd599567: [clang-tidy] Avoid C arrays check
Branches
Unknown
Tags
Unknown