HomePhabricator

[ASTMatchers] work around a miscompile; "NFC"

Authored by george.burgess.iv on Nov 22 2019, 8:03 PM.

Description

[ASTMatchers] work around a miscompile; "NFC"

I chatted with Reid offline, and we agreed that having a workaround here
would be appropriate until PR43879 is resolved.

The given transformation Works On My Machine(TM), and should hopefully
hold more broadly, but my fingers are crossed nonetheless. :)

Details

Auditors
stephanemoore
Committed
george.burgess.ivNov 22 2019, 8:11 PM
Parents
rG285cf9a84e1b: [IR] Move global_objects and global_values out of line, NFC
Branches
Unknown
Tags
Unknown

Event Timeline

stephanemoore accepted this commit.Dec 3 2019, 7:42 PM
stephanemoore added a subscriber: stephanemoore.

The changes look functionally safe.

Is the intention for the behavior to be functionally identical once PR43879 is resolved and the workaround is removed?

All concerns with this commit have now been addressed.Dec 3 2019, 7:42 PM

Thanks for reviewing!

Yeah, the intent is for this patch to be NFC for compilers which don't suffer from PR43879. As you noted, once PR43879 is fixed, we should be able to revert this without issue.

Thanks for the fix and for the confirmation! 👍