HomePhabricator

[DDG] Data Dependence Graph - Topological Sort (Memory Leak Fix)

Authored by bmahjour on Dec 2 2019, 12:23 PM.

Description

[DDG] Data Dependence Graph - Topological Sort (Memory Leak Fix)

Summary:
This fixes the memory leak in bec37c3fc766a7b97f8c52c181c325fd47b75259
and re-delivers the reverted patch.
In this patch the DDG DAG is sorted topologically to put the
nodes in the graph in the order that would satisfy all
dependencies. This helps transformations that would like to
generate code based on the DDG. Since the DDG is a DAG a
reverse-post-order traversal would give us the topological
ordering. This patch also sorts the basic blocks passed to
the builder based on program order to ensure that the
dependencies are computed in the correct direction.

Authored By: bmahjour

Reviewer: Meinersbur, fhahn, myhsu, xtian, dmgreen, kbarton, jdoerfert

Reviewed By: Meinersbur

Subscribers: ychen, arphaman, simoll, a.elovikov, mgorny, hiraditya, jfb, wuzish, llvm-commits, jsji, Whitney, etiotto, ppc-slack

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70609

Details

Committed
bmahjourDec 3 2019, 7:08 AM
Reviewer
Meinersbur
Differential Revision
D70609: [DDG] Data Dependence Graph - Topological Sort
Parents
rG970d9719ea0d: Precommit tests for D70673
Branches
Unknown
Tags
Unknown