HomePhabricator

Recommit "[Driver] Default to -fno-common for all targets"

Authored by SjoerdMeijer on Mar 9 2020, 3:07 AM.

Description

Recommit "[Driver] Default to -fno-common for all targets"

This includes fixes for:

  • test-suite: some benchmarks need to be compiled with -fcommon, see D75557.
  • compiler-rt: one test needed -fcommon, and another a change, see D75520.

Event Timeline

why "Default to -fno-common for all target" ?
this is a bug change. It make different action with other compilers. e.g GCC
So some common project or tests for both GCC and LLVM need to change to build files.

OK, I see GCC10 also defaults to -fno-common and so we get consistent behaviour with GCC.