HomePhabricator

Implement a rudimentary form of generic lambdas.

Authored by faisalv on Sep 26 2013, 12:54 PM.

Description

Implement a rudimentary form of generic lambdas.

Specifically, the following features are not included in this commit:

  • any sort of capturing within generic lambdas
  • generic lambdas within template functions and nested within other generic lambdas
  • conversion operator for captureless lambdas
  • ensuring all visitors are generic lambda aware (Although I have gotten some useful feedback on my patches of the above and will be incorporating that as I submit those patches for commit)

As an example of what compiles through this commit:

template <class F1, class F2>
struct overload : F1, F2 {

  using F1::operator();
  using F2::operator();
  overload(F1 f1, F2 f2) : F1(f1), F2(f2) { }
};

auto Recursive = [](auto Self, auto h, auto ... rest) {
  return 1 + Self(Self, rest...);
};
auto Base = [](auto Self, auto h) {
    return 1;
};
overload<decltype(Base), decltype(Recursive)> O(Base, Recursive);
int num_params =  O(O, 5, 3, "abc", 3.14, 'a');

Please see attached tests for more examples.

This patch has been reviewed by Doug and Richard. Minor changes (non-functionality affecting) have been made since both of them formally looked at it, but the changes involve removal of supernumerary return type deduction changes (since they are now redundant, with richard having committed a recent patch to address return type deduction for C++11 lambdas using C++14 semantics).

Some implementation notes:

  • Add a new Declarator context => LambdaExprParameterContext to clang::Declarator to allow the use of 'auto' in declaring generic lambda parameters
  • Add various helpers to CXXRecordDecl to facilitate identifying and querying a closure class
  • LambdaScopeInfo (which maintains the current lambda's Sema state) was augmented to house the current depth of the template being parsed (id est the Parser calls Sema::RecordParsingTemplateParameterDepth) so that SemaType.cpp::ConvertDeclSpecToType may use it to immediately generate a template-parameter-type when 'auto' is parsed in a generic lambda parameter context. (i.e we do NOT use AutoType deduced to a template parameter type - Richard seemed ok with this approach). We encode that this template type was generated from an auto by simply adding $auto to the name which can be used for better diagnostics if needed.
  • SemaLambda.h was added to hold some common lambda utility functions (this file is likely to grow ...)
  • Teach Sema::ActOnStartOfFunctionDef to check whether it is being called to instantiate a generic lambda's call operator, and if so, push an appropriately prepared LambdaScopeInfo object on the stack.
  • various tests were added - but much more will be needed.

There is obviously more work to be done, and both Richard (weakly) and Doug (strongly)
have requested that LambdaExpr be removed form the CXXRecordDecl LambdaDefinitionaData
in a future patch which is forthcoming.

A greatful thanks to all reviewers including Eli Friedman, James Dennett,
and especially the two gracious wizards (Richard Smith and Doug Gregor)
who spent hours providing feedback (in person in Chicago and on the mailing lists).
And yet I am certain that I have allowed unidentified bugs to creep in; bugs, that I will do my best to slay, once identified!

Thanks!

llvm-svn: 191453

Details

Committed
faisalvSep 26 2013, 12:54 PM
Parents
rGbcf81ea4bf0b: Fix a couple of typos in the help text for disassemble
Branches
Unknown
Tags
Unknown