HomePhabricator

[LoopUnroll] Remove remapInstruction().

Authored by Whitney on Jan 23 2020, 12:11 PM.

Description

[LoopUnroll] Remove remapInstruction().

Summary:
LoopUnroll can reuse the RemapInstruction() in ValueMapper, or
remapInstructionsInBlocks() in CloneFunction, depending on the needs.
There is no need to have its own version in LoopUnroll.

By calling RemapInstruction() without TypeMapper or Materializer and
with Flags (RF_NoModuleLevelChanges | RF_IgnoreMissingLocals), it does
the same as remapInstruction(). remapInstructionsInBlocks() calls
RemapInstruction() exactly as described.

Looking at the history, I cannot find any obvious reason to have its own
version.
Reviewer: dmgreen, jdoerfert, Meinersbur, kbarton, bmahjour, etiotto,
foad, aprantl
Reviewed By: jdoerfert
Subscribers: hiraditya, zzheng, llvm-commits, prithayan, anhtuyen
Tag: LLVM
Differential Revision: https://reviews.llvm.org/D73277

Details

Committed
WhitneyJan 27 2020, 7:42 AM
Reviewer
jdoerfert
Differential Revision
D73277: [LoopUnroll] Remove remapInstruction().
Parents
rGc963b5fbd61a: [test][llvm-dwarfdump] Add extra test case for invalid MD5 form
Branches
Unknown
Tags
Unknown