Diffusion LLVM Github Monorepo 2a4e704c92e8

Revert "Use uint64_t for branch weights instead of uint32_t"
2a4e704c92e8
Actions

Authored by • thakis on Oct 27 2020, 6:18 AM.

Description

Revert "Use uint64_t for branch weights instead of uint32_t"

This reverts commit e5766f25c62c185632e3a75bf45b313eadab774b.
Makes clang assert when building Chromium, see https://crbug.com/1142813
for a repro.

Details

Committed

• thakis

Oct 27 2020, 6:26 AM

Parents

rGb19473cf590e: [clang] RewriteObjCClassMetaData - remove superfluous null pointer check. NFCI.

Branches

Unknown

Tags

Unknown

Reverts

D88609: Use uint64_t for branch weights instead of uint32_t
rGe5766f25c62c: Use uint64_t for branch weights instead of uint32_t

Event Timeline

• thakis committed rG2a4e704c92e8: Revert "Use uint64_t for branch weights instead of uint32_t" (authored by • thakis).Oct 27 2020, 6:26 AM

• thakis added reverted changes: rGe5766f25c62c: Use uint64_t for branch weights instead of uint32_t, D88609: Use uint64_t for branch weights instead of uint32_t.

Changes (114)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

Path

Size

clang/

lib/

CodeGen/

CodeGenPGO.cpp

test/

CodeGen/

catch-undef-behavior.c

CodeGenCXX/

attr-likelihood-if-branch-weights.cpp

attr-likelihood-if-vs-builtin-expect.cpp

attr-likelihood-switch-branch-weights.cpp

microsoft-abi-thread-safe-statics.cpp

profile-remap.cpp

static-initializer-branch-weights.cpp

Profile/

c-captured.c

c-counter-overflows.c

gcc-flag-compatibility.c

objc-general.m

compiler-rt/

test/

profile/

Inputs/

Linux/

instrprof-override-filename-then-reset-default.c

instrprof-override-filename-with-env.c

instrprof-override-filename.c

instrprof-reset-counters.c

instrprof-set-filename-then-reset-default.c

instrprof-set-filename.c

instrprof-without-libc.c

instrprof-write-file-atexit-explicitly.c

instrprof-write-file-only.c

instrprof-write-file.c

llvm/

include/

llvm/

IR/

Instructions.h

MDBuilder.h

Transforms/

Scalar/

LowerExpectIntrinsic.h

Utils/

MisExpect.h

lib/

Analysis/

BranchProbabilityInfo.cpp

IR/

Instructions.cpp

MDBuilder.cpp

Transforms/

IPO/

SampleProfile.cpp

Instrumentation/

ControlHeightReduction.cpp

PGOInstrumentation.cpp

Scalar/

JumpThreading.cpp

LowerExpectIntrinsic.cpp

Utils/

test/

Analysis/

BranchProbabilityInfo/

basic.ll

basic_i32.ll

Instrumentation/

AddressSanitizer/

basic.ll

Transforms/

CodeExtractor/

MultipleExitBranchProb.ll

CorrelatedValuePropagation/

profmd.ll

JumpThreading/

threading_prof1.ll

threading_prof2.ll

update-edge-weight.ll

LoopUnroll/

peel-loop-pgo-deopt.ll

peel-loop-pgo.ll

runtime-loop-branchweight.ll

LoopVectorize/

check-prof-info.ll

tripcount.ll

LowerExpectIntrinsic/

basic.ll

expect-with-probability.ll

PGOProfile/

cspgo_profile_summary.ll

fix_entry_count.ll

icp_covariant_call_return.ll

icp_covariant_invoke_return.ll

icp_invoke.ll

icp_vararg.ll

indirect_call_promotion.ll

indirect_call_promotion_musttail.ll

indirect_call_promotion_vla.ll

multiple_hash_profile.ll

thinlto_indirect_call_promotion.ll

SCCP/

switch.ll

SampleProfile/

entry_counts_cold.ll

indirect-call.ll

inline-mergeprof-dup.ll

inline-mergeprof.ll

profile-format-compress.ll

profile-format.ll

SimpleLoopUnswitch/

basictest-profmd.ll

trivial-unswitch-profmd.ll

SimplifyCFG/

invoke_unwind.ll

preserve-branchweights-switch-create.ll

preserve-branchweights.ll

switch-profmd.ll

Util/

libcalls-shrinkwrap-double.ll

libcalls-shrinkwrap-float.ll

libcalls-shrinkwrap-long-double.ll

unittests/

Analysis/

ProfileSummaryInfoTest.cpp

rG2a4e704c92e8

View Options

clang/lib/CodeGen/CodeGenPGO.cpp

Load File

View Options

clang/test/CodeGen/catch-undef-behavior.c

Load File

View Options

clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp

Load File

View Options

clang/test/CodeGenCXX/attr-likelihood-if-vs-builtin-expect.cpp

Load File

View Options

clang/test/CodeGenCXX/attr-likelihood-switch-branch-weights.cpp

Load File

View Options

clang/test/CodeGenCXX/microsoft-abi-thread-safe-statics.cpp

Load File

View Options

clang/test/CodeGenCXX/profile-remap.cpp

Load File

View Options

clang/test/CodeGenCXX/static-initializer-branch-weights.cpp

Load File

View Options

clang/test/Profile/c-captured.c

Load File

View Options

clang/test/Profile/c-counter-overflows.c

Load File

View Options

clang/test/Profile/c-general.c

Load File

View Options

clang/test/Profile/cxx-class.cpp

Load File

View Options

clang/test/Profile/cxx-lambda.cpp

Load File

View Options

clang/test/Profile/cxx-rangefor.cpp

Load File

View Options

clang/test/Profile/cxx-templates.cpp

Load File

View Options

clang/test/Profile/cxx-throws.cpp

Load File

View Options

clang/test/Profile/gcc-flag-compatibility.c

Load File

View Options

clang/test/Profile/objc-general.m

Load File

View Options

compiler-rt/test/profile/Inputs/comdat_rename_1.cpp

Load File

View Options

compiler-rt/test/profile/Inputs/comdat_rename_2.cpp

Load File

View Options

compiler-rt/test/profile/Linux/instrprof-basic.c

Load File

View Options

compiler-rt/test/profile/Linux/instrprof-cs.c

Load File

View Options

compiler-rt/test/profile/instrprof-basic.c

Load File

View Options

compiler-rt/test/profile/instrprof-dump.c

Load File

View Options

compiler-rt/test/profile/instrprof-hostname.c

Load File

View Options

compiler-rt/test/profile/instrprof-override-filename-then-reset-default.c

Load File

View Options

compiler-rt/test/profile/instrprof-override-filename-with-env.c

Load File

View Options

compiler-rt/test/profile/instrprof-override-filename.c

Load File

View Options

compiler-rt/test/profile/instrprof-reset-counters.c

Load File

View Options

compiler-rt/test/profile/instrprof-set-filename-then-reset-default.c

Load File

View Options

compiler-rt/test/profile/instrprof-set-filename.c

Load File

View Options

compiler-rt/test/profile/instrprof-without-libc.c

Load File

View Options

compiler-rt/test/profile/instrprof-write-file-atexit-explicitly.c

Load File

View Options

compiler-rt/test/profile/instrprof-write-file-only.c

Load File

View Options

compiler-rt/test/profile/instrprof-write-file.c

Load File

View Options

llvm/include/llvm/IR/Instructions.h

Load File

View Options

llvm/include/llvm/IR/MDBuilder.h

Load File

View Options

llvm/include/llvm/Transforms/Scalar/LowerExpectIntrinsic.h

Load File

View Options

llvm/include/llvm/Transforms/Utils/MisExpect.h

Load File

View Options

llvm/lib/Analysis/BranchProbabilityInfo.cpp

Load File

View Options

llvm/lib/IR/Instructions.cpp

Load File

View Options

llvm/lib/IR/MDBuilder.cpp

Load File

View Options

llvm/lib/Transforms/IPO/SampleProfile.cpp

Load File

View Options

llvm/lib/Transforms/Instrumentation/ControlHeightReduction.cpp

Load File

View Options

llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

Load File

View Options

llvm/lib/Transforms/Scalar/JumpThreading.cpp

Load File

View Options

llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp

Load File

View Options

llvm/lib/Transforms/Utils/CodeExtractor.cpp

Load File

View Options

llvm/lib/Transforms/Utils/Local.cpp

Load File

View Options

llvm/lib/Transforms/Utils/MisExpect.cpp

Load File

View Options

llvm/lib/Transforms/Utils/SimplifyCFG.cpp

Load File

View Options

llvm/test/Analysis/BranchProbabilityInfo/basic.ll

Load File

View Options

llvm/test/Analysis/BranchProbabilityInfo/basic_i32.ll

Load File

View Options

llvm/test/Instrumentation/AddressSanitizer/basic.ll

Load File

View Options

llvm/test/Transforms/CodeExtractor/MultipleExitBranchProb.ll

Load File

View Options

llvm/test/Transforms/CorrelatedValuePropagation/profmd.ll

Load File

View Options

llvm/test/Transforms/JumpThreading/threading_prof1.ll

Load File

View Options

llvm/test/Transforms/JumpThreading/threading_prof2.ll

Load File

View Options

llvm/test/Transforms/JumpThreading/update-edge-weight.ll

Load File

View Options

llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt.ll

Load File

View Options

llvm/test/Transforms/LoopUnroll/peel-loop-pgo.ll

Load File

View Options

llvm/test/Transforms/LoopUnroll/runtime-loop-branchweight.ll

Load File

View Options

llvm/test/Transforms/LoopVectorize/check-prof-info.ll

Load File

View Options

llvm/test/Transforms/LoopVectorize/tripcount.ll

Load File

View Options

llvm/test/Transforms/LowerExpectIntrinsic/basic.ll

Load File

View Options

llvm/test/Transforms/LowerExpectIntrinsic/expect-with-probability.ll

Load File

View Options

llvm/test/Transforms/LowerExpectIntrinsic/expect_nonboolean.ll

Load File

View Options

llvm/test/Transforms/LowerExpectIntrinsic/phi_merge.ll

Load File

View Options

llvm/test/Transforms/LowerExpectIntrinsic/phi_or.ll

Load File

View Options

llvm/test/Transforms/LowerExpectIntrinsic/phi_tern.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/branch1.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/branch2.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/chr.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/criticaledge.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/cspgo_profile_summary.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/fix_entry_count.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/icp_covariant_call_return.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/icp_covariant_invoke_return.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/icp_invoke.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/icp_vararg.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/indirect_call_promotion.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/indirect_call_promotion_vla.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/indirectbr.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/instr_entry_bb.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/landingpad.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/loop1.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/loop2.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/memop_size_opt.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/multiple_hash_profile.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/noreturncall.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/remap.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/select1.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/select2.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/switch.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/thinlto_cspgo_use.ll

Load File

View Options

llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll

Load File

View Options

llvm/test/Transforms/SCCP/switch.ll

Load File

View Options

llvm/test/Transforms/SampleProfile/entry_counts_cold.ll

Load File

View Options

llvm/test/Transforms/SampleProfile/indirect-call.ll

Load File

View Options

llvm/test/Transforms/SampleProfile/inline-mergeprof-dup.ll

Load File

View Options

llvm/test/Transforms/SampleProfile/inline-mergeprof.ll

Load File

View Options

llvm/test/Transforms/SampleProfile/profile-format-compress.ll

Load File

View Options

llvm/test/Transforms/SampleProfile/profile-format.ll

Load File

View Options

llvm/test/Transforms/SimpleLoopUnswitch/basictest-profmd.ll

Load File

View Options

llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch-profmd.ll

Load File

View Options

llvm/test/Transforms/SimplifyCFG/invoke_unwind.ll

Load File

View Options

llvm/test/Transforms/SimplifyCFG/preserve-branchweights-switch-create.ll

Load File

View Options

llvm/test/Transforms/SimplifyCFG/preserve-branchweights.ll

Load File

View Options

llvm/test/Transforms/SimplifyCFG/switch-profmd.ll

Load File

View Options

llvm/test/Transforms/Util/libcalls-shrinkwrap-double.ll

Load File

View Options

llvm/test/Transforms/Util/libcalls-shrinkwrap-float.ll

Load File

View Options

llvm/test/Transforms/Util/libcalls-shrinkwrap-long-double.ll

Load File

View Options

llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp

Load File

Revert "Use uint64_t for branch weights instead of uint32_t"2a4e704c92e8Actions

Description

Details

Event Timeline

Changes (114)Show All Changes

Very Large Commit

rG2a4e704c92e8

clang/lib/CodeGen/CodeGenPGO.cpp

clang/test/CodeGen/catch-undef-behavior.c

clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp

clang/test/CodeGenCXX/attr-likelihood-if-vs-builtin-expect.cpp

clang/test/CodeGenCXX/attr-likelihood-switch-branch-weights.cpp

clang/test/CodeGenCXX/microsoft-abi-thread-safe-statics.cpp

clang/test/CodeGenCXX/profile-remap.cpp

clang/test/CodeGenCXX/static-initializer-branch-weights.cpp

clang/test/Profile/c-captured.c

clang/test/Profile/c-counter-overflows.c

clang/test/Profile/c-general.c

clang/test/Profile/cxx-class.cpp

clang/test/Profile/cxx-lambda.cpp

clang/test/Profile/cxx-rangefor.cpp

clang/test/Profile/cxx-templates.cpp

clang/test/Profile/cxx-throws.cpp

clang/test/Profile/gcc-flag-compatibility.c

clang/test/Profile/objc-general.m

compiler-rt/test/profile/Inputs/comdat_rename_1.cpp

compiler-rt/test/profile/Inputs/comdat_rename_2.cpp

compiler-rt/test/profile/Linux/instrprof-basic.c

compiler-rt/test/profile/Linux/instrprof-cs.c

compiler-rt/test/profile/instrprof-basic.c

compiler-rt/test/profile/instrprof-dump.c

compiler-rt/test/profile/instrprof-hostname.c

compiler-rt/test/profile/instrprof-override-filename-then-reset-default.c

compiler-rt/test/profile/instrprof-override-filename-with-env.c

compiler-rt/test/profile/instrprof-override-filename.c

compiler-rt/test/profile/instrprof-reset-counters.c

compiler-rt/test/profile/instrprof-set-filename-then-reset-default.c

compiler-rt/test/profile/instrprof-set-filename.c

compiler-rt/test/profile/instrprof-without-libc.c

compiler-rt/test/profile/instrprof-write-file-atexit-explicitly.c

compiler-rt/test/profile/instrprof-write-file-only.c

compiler-rt/test/profile/instrprof-write-file.c

llvm/include/llvm/IR/Instructions.h

llvm/include/llvm/IR/MDBuilder.h

llvm/include/llvm/Transforms/Scalar/LowerExpectIntrinsic.h

llvm/include/llvm/Transforms/Utils/MisExpect.h

llvm/lib/Analysis/BranchProbabilityInfo.cpp

llvm/lib/IR/Instructions.cpp

llvm/lib/IR/MDBuilder.cpp

llvm/lib/Transforms/IPO/SampleProfile.cpp

llvm/lib/Transforms/Instrumentation/ControlHeightReduction.cpp

llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

llvm/lib/Transforms/Scalar/JumpThreading.cpp

llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp

llvm/lib/Transforms/Utils/CodeExtractor.cpp

llvm/lib/Transforms/Utils/Local.cpp

llvm/lib/Transforms/Utils/MisExpect.cpp

llvm/lib/Transforms/Utils/SimplifyCFG.cpp

llvm/test/Analysis/BranchProbabilityInfo/basic.ll

llvm/test/Analysis/BranchProbabilityInfo/basic_i32.ll

llvm/test/Instrumentation/AddressSanitizer/basic.ll

llvm/test/Transforms/CodeExtractor/MultipleExitBranchProb.ll

llvm/test/Transforms/CorrelatedValuePropagation/profmd.ll

llvm/test/Transforms/JumpThreading/threading_prof1.ll

llvm/test/Transforms/JumpThreading/threading_prof2.ll

llvm/test/Transforms/JumpThreading/update-edge-weight.ll

llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt.ll

llvm/test/Transforms/LoopUnroll/peel-loop-pgo.ll

llvm/test/Transforms/LoopUnroll/runtime-loop-branchweight.ll

llvm/test/Transforms/LoopVectorize/check-prof-info.ll

llvm/test/Transforms/LoopVectorize/tripcount.ll

llvm/test/Transforms/LowerExpectIntrinsic/basic.ll

llvm/test/Transforms/LowerExpectIntrinsic/expect-with-probability.ll

llvm/test/Transforms/LowerExpectIntrinsic/expect_nonboolean.ll

llvm/test/Transforms/LowerExpectIntrinsic/phi_merge.ll

llvm/test/Transforms/LowerExpectIntrinsic/phi_or.ll

llvm/test/Transforms/LowerExpectIntrinsic/phi_tern.ll

llvm/test/Transforms/PGOProfile/branch1.ll

llvm/test/Transforms/PGOProfile/branch2.ll

llvm/test/Transforms/PGOProfile/chr.ll

Revert "Use uint64_t for branch weights instead of uint32_t"
2a4e704c92e8
Actions

Changes (114)
Show All Changes