HomePhabricator

[clang-format] Don't break multi block parameters on…

Authored by ghvg1313 on Apr 6 2020, 12:45 PM.

Description

[clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

Summary:
While the original diff makes a lot of sense, and multiple inline block parameter/trailing paramemter after inline block paramemter should be discouraged, the formatting result is different than what xcode does by default
For the exact same example provided in the original diff:

[object
  blockArgument:^{
    a = 42;
  }
     anotherArg:42];

The code is hard to read and not very visually pleasing

This diff uses ObjCBreakBeforeNestedBlockParam to shield from the formatting
When it's set to false, don't allign the inline block paramemters.

Reviewers: jolesiak, benhamilton, jinlin

Reviewed By: jolesiak

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77039