HomePhabricator

DebugInfo: Add missing comment from llvm/test/DebugInfo/X86/debug-macro-dwo.ll

Authored by dblaikie on Jul 21 2020, 1:35 PM.

Description

DebugInfo: Add missing comment from llvm/test/DebugInfo/X86/debug-macro-dwo.ll

Meant to include this in 63a45091e5f3fce525d7bb8823df95a468ae69d0

Details

Committed
dblaikieJul 21 2020, 1:36 PM
Parents
rG23ff4e4f5d65: Revert "[clangd] Fixes in lit tests"
Branches
Unknown
Tags
Unknown

Event Timeline

MaskRay added inline comments.
/llvm/test/DebugInfo/X86/debug-macro-dwo.ll
14

I think for comments in .ll files ;; might be a good choice.

; FIXME: may be considered a check prefix by a rigid lit/FileCheck (IIRC some folks are enhancing lit/FileCheck diagnostics on unused check prefixes)

dblaikie marked an inline comment as done.Jul 21 2020, 2:10 PM
dblaikie added inline comments.
/llvm/test/DebugInfo/X86/debug-macro-dwo.ll
14

Seems there's a lot of instances of FIXME in the test suite already, so such a FileCheck change would have to do some broad-scale cleanup & adding one more doesn't seem like it'll change things much.

As for the double comment character - I know a few folks have been pushing this, but I'm not entirely convinced of the value add across the whole test suite. It seems pretty clear to a reader that this is a comment, with lots of free-form text?