Diffusion LLVM Github Monorepo 2508ef014e8b

[SelectionDAG] Remove unused FP constant in getNegatedExpression
2508ef014e8b
Actions

Authored by qiucf on Sep 15 2020, 2:59 AM.

Description

[SelectionDAG] Remove unused FP constant in getNegatedExpression

960cbc53 immediately removes nodes that won't be used to avoid
compilation time explosion. This patch adds the removal to constants to
fix PR47517.

Reviewed By: RKSimon, steven.zhang

Differential Revision: https://reviews.llvm.org/D87614

Details

Committed

qiucf

Sep 15 2020, 2:59 AM

Reviewer

RKSimon

Differential Revision

D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression

Parents

rG5f13d6c1eef7: [Transforms][Coroutines] Add missing header path to CMakeLists.txt

Branches

Unknown

Tags

Unknown

Event Timeline

qiucf added an edge: D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression.Sep 15 2020, 3:04 AM

qiucf committed rG2508ef014e8b: [SelectionDAG] Remove unused FP constant in getNegatedExpression (authored by qiucf).Sep 15 2020, 2:59 AM

This seems causing an address sanitizer failure: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/46121/steps/check-llvm%20asan/logs/stdio

The bug vanishes by reverting D86689's change. Investigating into it.

qiucf mentioned this in rGe1669843f2aa: Revert "[SelectionDAG] Remove unused FP constant in getNegatedExpression".Sep 15 2020, 7:06 AM

qiucf mentioned this in rGa2fb5446be96: [SelectionDAG] Check any use of negation result before removal.Sep 17 2020, 1:07 AM

qiucf mentioned this in rGb326d4ff946d: [SelectionDAG] Don't remove unused negated constant immediately.Oct 5 2020, 10:17 AM

Changes (2)

Path

Size

llvm/

lib/

CodeGen/

SelectionDAG/

TargetLowering.cpp

test/

CodeGen/

X86/

pr47517.ll

rG2508ef014e8b

View Options

llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp