HomePhabricator

[MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one…

Authored by jurahul on Dec 28 2020, 1:34 PM.

Description

[MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update.

  • Change FunctionLike::setAllArgAttrs() and setAllResultAttrs() to rebuild the new list of function attributes locally and call setAttr() just once instead of calling setArgAttr()/setResultAttrs() for each argument which incrementally build the attribute dictionary and can end up creating a lot of unused DictionaryAttr's (which are uniqued and nor garbage collected).

Differential Revision: https://reviews.llvm.org/D93870