HomePhabricator

[lldb] [testsuite] Fix a regression of TestCppScope.py

Authored by jankratochvil on Apr 18 2020, 1:44 AM.

Description

[lldb] [testsuite] Fix a regression of TestCppScope.py

This is a regression since:

[lldb][NFC] Modernize lang/cpp/scope test
acb0b99c8e4f1dc65a7f1e26da9db77239a67da7
rGacb0b99c8e4f

File "/home/jkratoch/redhat/llvm-monorepo/lldb/test/API/lang/cpp/scope/TestCppScope.py", line 19, in test
  self.assertEqual(global_var_names, expected_var_names)
AssertionError: Lists differ: ['C::a', 'A::a', 'B::a', '::a'... != ['A::a', 'B::a', 'C::a', '::a'...
First differing element 0:
C::a
A::a
- ['C::a', 'A::a', 'B::a', '::a']
+ ['A::a', 'B::a', 'C::a', '::a']

ManualDWARFIndex using NameToDIE does not sort alphabetically:

// This is only for uniqueness, not lexicographical ordering, so we can
// just compare pointers.
return uintptr_t(lhs.GetCString()) < uintptr_t(rhs.GetCString());

Details

Committed
jankratochvilApr 18 2020, 1:46 AM
Parents
rG60ce987bf31d: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now
Branches
Unknown
Tags
Unknown