HomePhabricator

[NARY-REASSOCIATE] Support reassociation of min/max
Concern Raised2388aae401dc

Authored by Evgeniy Brevnov <ybrevnov@azul.com> on Mar 2 2021, 12:14 AM.

Description

[NARY-REASSOCIATE] Support reassociation of min/max

Support reassociation for min/max. With that we should be able to transform min(min(a, b), c) -> min(min(a, c), b) if min(a, c) is already available.

Reviewed By: mkazantsev, lebedev.ri

Differential Revision: https://reviews.llvm.org/D88287

Details

Event Timeline

critson raised a concern with this commit.Apr 6 2021, 7:24 PM
critson added a subscriber: critson.

This code goes into an infinite loop on AMDGPU backend.
See attached bugpoint test case:
llc -march=amdgcn -mcpu=gfx700 < bugpoint-reduced-simplified.ll

This is the same failure as when previously committed: https://reviews.llvm.org/rG83d134c3c4222e8b8d3d90c099f749a3b3abc8e0

This commit now has outstanding concerns.Apr 6 2021, 7:24 PM