HomePhabricator

Improve DWARF parsing and accessing by 1% to 2%

Authored by clayborg on May 30 2019, 8:21 AM.

Description

Improve DWARF parsing and accessing by 1% to 2%

When LLDB first started we didn't have our mmap of the DWARF data done correctly and if the backing file would change we would get live changes as the file changed and it would cause problems. We now mmap correctly and do not run into these issues. There was legacy code in DWARFDebugInfoEntry::GetAbbreviationDeclarationPtr(...) that would always extract the abbrev index each time the function was called to verify that DWARF data hadn't changed and a warning was emitted if it did. We no longer need this and the code was removed. The other thing this function did when it parsed the abbrev index was give us the offset of the first attribute bytes by adding the LEB128 size to the offset. This required an extra parameter to DWARFDebugInfoEntry::GetAbbreviationDeclarationPtr(...) which is now removed. I added "lldb::offset_t DWARFDebugInfoEntry::GetFirstAttributeOffset() const" which calculates this when we need it and modified all sites that need the offset to call it.

Now that we aren't decoding and verifying the abbrev index, it speeds up DWARF access by 1% to 2%.

Differential Revision: https://reviews.llvm.org/D62634

llvm-svn: 362103

Details

Committed
clayborgMay 30 2019, 8:21 AM
Differential Revision
D62634: Improve DWARF parsing and accessing by 1% to 2%
Parents
rGf61b5481fd2c: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode.
Branches
Unknown
Tags
Unknown