HomePhabricator

Fix a crash when parsing incorrect DWARF

Authored by labath on Nov 14 2018, 3:12 AM.

Description

Fix a crash when parsing incorrect DWARF

Summary:
While parsing a childless compile unit DIE we could crash if the DIE was
followed by any extra data (such as a superfluous end-of-children
marker). This happened because the break-on-depth=0 check was performed
only when parsing the null DIE, which was not correct because with a
childless root DIE, we could reach the end of the unit without ever
encountering the null DIE.

If the compile unit contribution ended directly after the CU DIE,
everything would be fine as we would terminate parsing due to reaching
EOF. However, if the contribution contained extra data (perhaps a
superfluous end-of-children marker), we would crash because we would
treat that data as the begging of another compile unit.

This fixes the crash by moving the depth=0 check to a more generic
place, and also adds a regression test.

Reviewers: clayborg, jankratochvil, JDevlieghere

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D54417

llvm-svn: 346849

Details

Committed
labathNov 14 2018, 3:12 AM
Differential Revision
D54417: Fix a crash when parsing incorrect DWARF
Parents
rG98963db57d04: [LLDB] - Support the single file split DWARF.
Branches
Unknown
Tags
Unknown