HomePhabricator

[lldb] Actually enable wchar support in Editline when it is defined in the host…

Authored by teemperor on Dec 10 2019, 5:17 AM.

Description

[lldb] Actually enable wchar support in Editline when it is defined in the host config

Summary:
Our Editline implementation in LLDB supports using the wchar interface of Editline which
should improve handling of unicode input when using Editline. At the moment we essentially
just ignore unicode input and echo the escaped unicode code point (\U1234) to the command line
(which we then also incorrectly treat as multiple characters, so console navigation is also broken afterwards).

This patch just adds the include to the host config file which already contains the LLDB_EDITLINE_USE_WCHAR
define to enable the Editline support (we just never included it in the file before). With this we now actually
echo back unicode characters on macOS and we no longer ignore unicode input. On Linux this doesn't
seem to improve the echoing back of characters but at least it fixes that we ignore unicode input.

Reviewers: labath

Reviewed By: labath

Subscribers: JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D71251

Details

Committed
teemperorDec 10 2019, 5:30 AM
Reviewer
labath
Differential Revision
D71251: [lldb] Actually enable wchar support in Editline when it is defined in the host config
Parents
rG06b0228e8036: add test for previous commit
Branches
Unknown
Tags
Unknown