HomePhabricator

[SelectionDAG] Don't remove unused negated constant immediately
121babae56e9Unpublished

Authored by qiucf on Oct 5 2020, 9:45 AM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[SelectionDAG] Don't remove unused negated constant immediately

This reverts partial of a2fb5446 (actually, 2508ef01) about removing
negated FP constant immediately if it has no uses. However, as discussed
in bug 47517, there're cases when NegX is folded into constant from
other places while NegY is removed by that line of code and NegX is
equal to NegY. In these cases, NegX is deleted before used and crash
happens. So revert the code and add necessary test case.

(cherry picked from commit b326d4ff946d2061a566a3fcce9f33b484759fe0)

Details

Committed
hansOct 6 2020, 7:04 AM
Parents
rGf80e6d634230: ReleaseNotes: mention the machine outliner for ARM
Branches
Unknown
Tags
Unknown

Event Timeline