HomePhabricator

[libc++][ci] Detect not committed generated files.

Authored by Mordante on Jul 22 2021, 2:17 AM.

Description

[libc++][ci] Detect not committed generated files.

The Generated output CI job only tests for modified files. This job
should also fail the generated output contains new files.

It would be possible to test modified and untracked files in one
execution of git ls-files. However the diff is stored as an artifact
so the execution of git diff would still be required.

Discussion: Would it be better to do git ls-files -om and remove the
excution of
! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false ?
(Obviously then the name generated_output.untracked should change to
something like generated_output.status)

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D106534

Details

Committed
MordanteJul 26 2021, 7:41 AM
Reviewer
Restricted Project
Differential Revision
D106534: [libc++][ci] Detect not committed generated files.
Parents
rG33146857e984: [IR] Consider non-willreturn as side effect (PR50511)
Branches
Unknown
Tags
Unknown