HomePhabricator

Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"

Authored by teemperor on Aug 21 2020, 5:21 AM.

Description

Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"

The orignal patch with the missing 'REQUIRES: asserts' as there is a debug-only
flag used in the test.

Original summary:

D81347 changes the ASTFileSignature to be an array of 20 uint8_t instead of 5
uint32_t. However, it didn't update the code in ObjectFilePCHContainerOperations
that creates the dwoID in the module from the ASTFileSignature
(Buffer->Signature being the array subclass that is now `std::array<uint8_t,
20> instead of std::array<uint32_t, 5>`).

uint64_t Signature = [..] (uint64_t)Buffer->Signature[1] << 32 | Buffer->Signature[0]

This code works with the old ASTFileSignature (where two uint32_t are enough to
fill the uint64_t), but after the patch this only took two bytes from the
ASTFileSignature and only partly filled the Signature uint64_t.

This caused that the dwoID in the module ref and the dwoID in the actual module
no longer match (which in turns causes that LLDB keeps warning about the dwoID's
not matching when debugging -gmodules-compiled binaries).

This patch just unifies the logic for turning the ASTFileSignature into an
uint64_t which makes the dwoID match again (and should prevent issues like that
in the future).

Reviewed By: aprantl, dang

Differential Revision: https://reviews.llvm.org/D84013

Details

Committed
teemperorAug 24 2020, 5:52 AM
Reviewer
aprantl
Differential Revision
D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)
Parents
rG577f8b157a03: [Fixed Point] Add codegen for fixed-point shifts.
Branches
Unknown
Tags
Unknown