HomePhabricator

[WebAssembly] Improve clang diagnostics for wasm attributes

Authored by sunfishcode on Jun 5 2020, 2:27 PM.

Description

[WebAssembly] Improve clang diagnostics for wasm attributes

This patch addresses the review comments on r352930:

  • Removes redundant diagnostic checking code
  • Removes errnoneous use of diag::err_alias_is_definition, which turned out to be ineffective anyway since functions can be defined later in the translation unit and avoid detection.
  • Adds a test for various invalid cases for import_name and import_module.

This reapplies D59520, with the addition of adding
InGroup<IgnoredAttributes> to the new warnings, to fix the
Misc/warning-flags.c failure.

Differential Revision: https://reviews.llvm.org/D59520

Details

Committed
sunfishcodeJun 5 2020, 2:32 PM
Differential Revision
D59520: [WebAssembly] Address review comments on r352930
Parents
rG8b05b6d53342: [X86] Add test cases for PR46203. NFC
Branches
Unknown
Tags
Unknown