HomePhabricator

[clang] Emit type metadata on available_externally vtables for WPD

Authored by tejohnson on Feb 16 2021, 7:44 PM.

Description

[clang] Emit type metadata on available_externally vtables for WPD

When WPD is enabled, via WholeProgramVTables, emit type metadata for
available_externally vtables. Additionally, add the vtables to the
llvm.compiler.used global so that they are not prematurely eliminated
(before *LTO analysis).

This is needed to avoid devirtualizing calls to a function overriding a
class defined in a header file but with a strong definition in a shared
library. Without type metadata on the available_externally vtables from
the header, the WPD analysis never sees what a derived class is
overriding. Even if the available_externally base class functions are
pure virtual, because shared library definitions are already treated
conservatively (committed patches D91583, D96721, and D96722) we will
not devirtualize, which would be unsafe since the library might contain
overrides that aren't visible to the LTO unit.

An example is std::error_category, which is overridden in LLVM
and causing failures after a self build with WPD enabled, because
libstdc++ contains hidden overrides of the virtual base class methods.

Differential Revision: https://reviews.llvm.org/D96919

Details

Committed
tejohnsonFeb 19 2021, 12:42 PM
Differential Revision
D96919: [clang] Emit type metadata on available_externally vtables for WPD
Parents
rGefc8f3311b57: [msan] Set cmpxchg shadow precisely
Branches
Unknown
Tags
Unknown