HomePhabricator

Standard-to-LLVM conversion: check that operands have LLVM types

Authored by ftynse on Oct 10 2019, 4:25 PM.

Description

Standard-to-LLVM conversion: check that operands have LLVM types

In Standard to LLVM dialect conversion, the binary op conversion pattern
implicitly assumed some operands were of LLVM IR dialect type. This is not
necessarily true, for example if the Ops that produce those operands did not
match the existing convresion patterns. Check if all operands are of LLVM IR
dialect type and if not, fail to patch the binary op pattern.

Closes tensorflow/mlir#168

PiperOrigin-RevId: 274063207

Details

Committed
jpienaarOct 10 2019, 5:19 PM
Parents
rG4dde19f02473: Translation to LLVM: check the validity of module-level Ops
Branches
Unknown
Tags
Unknown

Event Timeline